Don't rewrite floats and don't break e+ syntax #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parses floats into their text as-is, without rewriting anything. This means that floats like `0.068` aren't rewritten as 6.8e-2 anymore. However, `.0` is also not rewritten as `0.0` anymore. - Fixes a parsing bug that caused `1.e+0` to be formatted as `1.e + 0`, which is invalid syntax
WilliButz
approved these changes
Aug 30, 2024
infinisil
commented
Sep 3, 2024
piegamesde
approved these changes
Sep 3, 2024
0x4A6F
approved these changes
Sep 3, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-09-03/51584/1 |
|
Would be great if we could land this in nixpkgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
0.068aren't rewritten as 6.8e-2 anymore. However,.0is also not rewritten as0.0anymore.1.e+0to be formatted as1.e + 0, which is invalid syntaxThis work is sponsored by Antithesis ✨